Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other Package Godocs for Prysm #5681

Merged
merged 8 commits into from
Apr 29, 2020
Merged

Conversation

rauljordan
Copy link
Contributor

What type of PR is this?

Documentation

What does this PR do? Why is it needed?

This PR adds go docs to endtoend, slasher, validator, and the various shared packages in prysm.

Which issues(s) does this PR fix?

Part of #5599

Other notes for review

@rauljordan rauljordan requested a review from a team as a code owner April 29, 2020 16:54
@rauljordan rauljordan self-assigned this Apr 29, 2020
@rauljordan rauljordan marked this pull request as draft April 29, 2020 16:54
prestonvanloon
prestonvanloon previously approved these changes Apr 29, 2020
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #5681 into master will increase coverage by 19.52%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5681       +/-   ##
===========================================
+ Coverage   26.90%   46.43%   +19.52%     
===========================================
  Files         239      308       +69     
  Lines       21259    25844     +4585     
===========================================
+ Hits         5720    12000     +6280     
+ Misses      14423    11994     -2429     
- Partials     1116     1850      +734     

@rauljordan rauljordan marked this pull request as ready for review April 29, 2020 18:39
Copy link
Contributor

@0xKiwi 0xKiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 546196a into master Apr 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the other-package-godocs branch April 29, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants