-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other Package Godocs for Prysm #5681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into other-package-godocs
prestonvanloon
previously approved these changes
Apr 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #5681 +/- ##
===========================================
+ Coverage 26.90% 46.43% +19.52%
===========================================
Files 239 308 +69
Lines 21259 25844 +4585
===========================================
+ Hits 5720 12000 +6280
+ Misses 14423 11994 -2429
- Partials 1116 1850 +734 |
rauljordan
requested review from
prestonvanloon,
nisdas,
terencechain and
a team
April 29, 2020 18:40
0xKiwi
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR adds go docs to endtoend, slasher, validator, and the various shared packages in prysm.
Which issues(s) does this PR fix?
Part of #5599
Other notes for review