Stagger Block By Range Responses #5618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
changed the title
terencechain
requested changes
Apr 25, 2020
|
|
||
| r.blocksRateLimiter.Add(stream.Conn().RemotePeer().String(), int64(m.Count)) | ||
| // TODO(3147): Update this with reasonable constraints. | ||
| if endSlot-startSlot > 1000 || m.Step == 0 { |
There was a problem hiding this comment.
what is this 1000 magic number? should we define it at the top and use a const?
There was a problem hiding this comment.
Not actually sure, we have had it for as long as I can remember
@prestonvanloon any idea why its 1000 ?
There was a problem hiding this comment.
There is no reason. I put 1000 because I felt that was a large range and anything more than that would be too much to fetch from the DB at once.
| r.blocksRateLimiter.Add(stream.Conn().RemotePeer().String(), int64(m.Count)) | ||
| // TODO(3147): Update this with reasonable constraints. | ||
| if endSlot-startSlot > 1000 || m.Step == 0 { | ||
| r.writeErrorResponseToStream(responseCodeInvalidRequest, "invalid range or step", stream) |
There was a problem hiding this comment.
can prefine err "invalid range or step" and use it here and L81
Co-Authored-By: terence tsao <[email protected]>
Co-Authored-By: terence tsao <[email protected]>
terencechain
previously approved these changes
Apr 25, 2020
farazdagi
previously approved these changes
Apr 25, 2020
Co-Authored-By: Victor Farazdagi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5618 +/- ##
======================================
Coverage 1.47% 1.47%
======================================
Files 69 69
Lines 6516 6516
======================================
Hits 96 96
Misses 6411 6411
Partials 9 9 |
prestonvanloon
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context #5587.
Lighthouse peers were being constantly rate limited by prysm peers due to them request multiple batches of size 64 blocks. These requests being sent at once triggered our rate limiter. To make it easier for other clients asking for bigger batches of blocks, we instead stagger our block responses.
If the requested block range is greater than the alloted
blocksPerSecondvariable, we instead wait one second before sending the next batch over. This prevents prysm from being overwhelmed when serving multiple large requests at once. By spreading out the request over 10 seconds(response deadline), we prevent the rate limiter from being triggered and also allow prysm to serve large requests.