Fix activationEpoch=FarFutureEpoch in validator client logging #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5608 +/- ##
===========================================
- Coverage 43.21% 12.92% -30.30%
===========================================
Files 271 116 -155
Lines 22596 9279 -13317
===========================================
- Hits 9765 1199 -8566
+ Misses 11075 7876 -3199
+ Partials 1756 204 -1552 |
terencechain
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of a case where a validator is in the state, past the DEPOSITED state, but still not assigned a ActivationEpoch. I misunderstood how the activation process works.