feature default validator keystore path #5592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
added
Ready For Review
0xKiwi
approved these changes
Apr 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5438
--passwordflag, keystore path input was expected from user too - even when--keystore-pathis provided)DefaultValidatorDir()to accounts processing, and allows keystore manager to access it to. Effectively, now it is not required to provide path at all - as it will default to OS-specific one and will be used in both account creation and validator node runningprysm.shworks) and merge (and publish) removes --keystore-path flag prysm-testnet-site#117With this PR, when new validator account creation is requested, it features default path:
