Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No More EthereumAPIs Patch #5570

Merged
merged 5 commits into from
Apr 22, 2020
Merged

No More EthereumAPIs Patch #5570

merged 5 commits into from
Apr 22, 2020

Conversation

rauljordan
Copy link
Contributor

Resolves #5130


Description

Write why you are making the changes in this pull request

We have decided to include all patched changes upstream in ethereumapis. This PR removes all patching logic and updates the dependency to its latest version in Prysm.

@rauljordan rauljordan requested review from prestonvanloon and a team as code owners April 21, 2020 20:39
@rauljordan rauljordan requested review from farazdagi and nisdas April 21, 2020 20:39
@rauljordan rauljordan self-assigned this Apr 21, 2020
prestonvanloon
prestonvanloon previously approved these changes Apr 21, 2020
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance, patch!

terencechain
terencechain previously approved these changes Apr 21, 2020
@rauljordan rauljordan dismissed stale reviews from terencechain and prestonvanloon via 916803f April 21, 2020 21:57
@prylabs-bulldozer prylabs-bulldozer bot merged commit 793c3d2 into master Apr 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the no-more-patch branch April 22, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor build to not use patches on ethereumapi
3 participants