Add post-genesis deposit testing to long-running E2E #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e2e-add-depsoits
…e2e-add-depsoits
…e2e-add-depsoits
0xKiwi
changed the title
prestonvanloon
requested changes
Apr 26, 2020
endtoend/evaluators/validator.go
Outdated
| @@ -46,6 +49,13 @@ func afterNthEpoch(afterEpoch uint64) func(uint64) bool { | |||
| } | |||
| } | |||
|
|
|||
| // Not including first epoch because of issues with genesis. | |||
| func betweenEpochs(fromEpoch uint64, toEpoch uint64) func(uint64) bool { | |||
There was a problem hiding this comment.
please change to boolean type name
Suggested change
| func betweenEpochs(fromEpoch uint64, toEpoch uint64) func(uint64) bool { | |
| func isBetweenEpochs(fromEpoch uint64, toEpoch uint64) func(uint64) bool { |
endtoend/long_minimal_e2e_test.go
Outdated
| var err error | ||
| if epochs, ok := os.LookupEnv("E2E_EPOCHS"); ok { | ||
| if !ok { | ||
| return |
There was a problem hiding this comment.
Suggested change
| return | |
| t.Skip("E2E_EPOCHS not set") |
endtoend/long_minimal_e2e_test.go
Outdated
| var err error | ||
| if epochs, ok := os.LookupEnv("E2E_EPOCHS"); ok { | ||
| if !ok { | ||
| t.Skip("E2E EPOCHS not set") |
There was a problem hiding this comment.
Suggested change
| t.Skip("E2E EPOCHS not set") | |
| t.Skip("E2E_EPOCHS not set") |
…to e2e-add-depsoits
|
@0xKiwi can we open future PR's into prysm directly so that bulldozer can auto-update? (it doesn't always work, but it can help sometimes). @prestonvanloon ready for another look |
rauljordan
approved these changes
Apr 27, 2020
prestonvanloon
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deposit testing support to E2E to fully test validator deposits and activation.
Due to the time it takes to test this, it is only run as part of the "Long Running" E2E, now split up into its own file.
If E2E_EPOCHS is not set, the test will not run. Testing show allow for at least 16 epochs to ensure deposited validators are performing correctly.