Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect reset value for extruder steps per unit in experimental settings #4330

Open
joshuafocht opened this issue Dec 3, 2024 · 10 comments
Labels
bug Something isn't working.

Comments

@joshuafocht
Copy link

Printer model

MINI+

Firmware version

6.1.2

Upgrades and modifications

filament runout sensor

Printing from...

USB Drive, PrusaLink, and Prusa Connect

Describe the bug

When resetting the extruder steps per unit under experimental settings it defaults to 1 not the stock value of 325 (for a mini/+).

How to reproduce

  1. Goto experimental settings by holding click on the Hardware menu of Settings for 2-3 seconds.
  2. Click reset extruder steps per unit.
  3. Extruder steps per unit gets set to 1.

Expected behavior

Clicking reset extruder steps per second should set it to 325 not 1. (For the mini/+)

Files

https://1drv.ms/v/s!ArmBR5ZkHUhmk8tYQyPg-7nA_JrzDQ?e=joetqc

@joshuafocht joshuafocht added the bug Something isn't working. label Dec 3, 2024
@bkerler
Copy link
Contributor

bkerler commented Dec 8, 2024

@joshuafocht I'm looking into this issue.

So far I couldn't see any issue that might cause this at first sight, so I will try to emulate to see what goes wrong.

Just for reference for the other devs:

Item<MI_STEPS_PER_UNIT_E>().SetVal(config_store().axis_steps_per_unit_e0.default_val);

Being set here:

StoreItem<float, defaults::axis_steps_per_unit_e0, journal::hash("Axis Steps Per Unit E0")> axis_steps_per_unit_e0;

Which is hardcoded to 325 here:

{ 100, 100, 400, 325 } //E0 280 295

@bkerler
Copy link
Contributor

bkerler commented Dec 8, 2024

Most probably caused by this :

default_axis_steps_flt[3] * ((DEFAULT_INVERT_E0_DIR == true) ? -1.f : 1.f), // AXIS_STEPS_PER_UNIT_E0

@bkerler
Copy link
Contributor

bkerler commented Dec 8, 2024

@joshuafocht Two questions:

  1. Do you use the release or debug firmware ?
  2. Did you try to reset the eeprom and the bug still consists ?
    Thanks

@joshuafocht
Copy link
Author

I use the release firmware.
I do not know how to reset the eeprom, so if you can tell me how to do that I would be happy to try.

@bkerler
Copy link
Contributor

bkerler commented Dec 12, 2024

@joshuafocht Using "Settings->System->Factory Reset->Reset Settings & Calibrations". But I just verified the bug happens in the simulator as well, so no need to reset the eeprom. I will try to sort out what happens now.

@bkerler
Copy link
Contributor

bkerler commented Dec 12, 2024

Ok, we identified the issue and I wrote a PR for it :)

@joshuafocht
Copy link
Author

joshuafocht commented Dec 12, 2024

Thanks for your help!

@joshuafocht
Copy link
Author

joshuafocht commented Dec 12, 2024

Is this just a GUI issue?
Because when I tried to print it was barley extruding.

@bkerler
Copy link
Contributor

bkerler commented Dec 13, 2024

It is a GUI issue leading that an incorrect value is written to eeprom incorrectly after reset. To be precise, the extruder is inverse, so in fact it isn't 325 but -325 in reality. As the value is below 1 and the slider goes from 1 to 999 (I think), the value is being set to 1.
Until the firmware is fixed, make sure to set it to 325 after resetting.

@joshuafocht
Copy link
Author

Ok, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants