Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vesting accounts: Add to existing account #945

Open
4 tasks
SpicyLemon opened this issue Jul 18, 2022 · 2 comments
Open
4 tasks

Vesting accounts: Add to existing account #945

SpicyLemon opened this issue Jul 18, 2022 · 2 comments
Labels
bank Bank Module enhancement New feature or request
Milestone

Comments

@SpicyLemon
Copy link
Contributor

SpicyLemon commented Jul 18, 2022

Summary

Allow vesting coins and schedules to be added to an existing account.

Problem Definition

As the recipient of vesting funds, I want them added to my existing account so that I don't have to maintain as many accounts/keys/secrets.

Currently, a new account must be created as a vesting account in order to have vesting coins/schedule. This is problematic because:

  1. The account should be owned by the recipient, but must be created by the granter. This requires the recipient to create new keys and communicate the fresh address to the granter each time a grant is to be made.
  2. A recipient that has multiple vesting grants must manage the keys for all of them which can become cumbersome.

Proposal

Make an enhancement to our fork of Cosmos-SDK that will allow the addition of vesting coin/schedules to existing accounts. This should allow adding vesting coin/schedules to an account that doesn't yet have vesting coin/schedules. This should also allow adding extra vesting coin/schedules to an account that already has vesting coin/schedules. If an account already has vesting coin/schedules, the existing vesting coin/schedules should not be changed when adding the new coin/schedules.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
This was referenced Jul 18, 2022
@dwedul-figure dwedul-figure added enhancement New feature or request bank Bank Module labels Jul 18, 2022
@iramiller iramiller added this to the v1.14.0 milestone Sep 21, 2022
@iramiller iramiller modified the milestones: v1.14.0, v1.15.0 Jan 25, 2023
@iramiller iramiller modified the milestones: v1.15.0, v1.16.0 Apr 12, 2023
@iramiller iramiller modified the milestones: v1.16.0, v1.17.0 May 15, 2023
@SpicyLemon SpicyLemon modified the milestones: v1.17.0, v1.18.0 Sep 6, 2023
@iramiller iramiller modified the milestones: v1.18.0, v1.19.0 Jan 4, 2024
@iramiller
Copy link
Member

We should consider using a hold module/encumbrance model for this.

@SpicyLemon SpicyLemon modified the milestones: v1.19.0, v1.20.0 Jul 15, 2024
@SpicyLemon
Copy link
Contributor Author

The SDK has some changes coming related to vesting accounts. I think they're renaming them to "locked" accounts (or something like that). But that combined with the changes to the x/auth module, and creation of x/accounts should help us with this issue.

@iramiller iramiller modified the milestones: v1.20.0, v1.21.0 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bank Bank Module enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants