Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scope addresses for attributes #631

Closed
4 tasks
iramiller opened this issue Feb 1, 2022 · 0 comments · Fixed by #634
Closed
4 tasks

Allow scope addresses for attributes #631

iramiller opened this issue Feb 1, 2022 · 0 comments · Fixed by #634
Assignees
Labels
attribute Attribute Module enhancement New feature or request metadata Metadata Module
Milestone

Comments

@iramiller
Copy link
Member

Summary

As part of the upcoming asset classification system scopes will need to be able to have attributes assigned to them. In order for this to work the allowed bech32 address prefixes will need to be extended to allow scope in addition to tp and pb used for normal accounts.

Problem Definition

The asset classification program uses controlled names owned by the Provenance foundation and delegated representatives to create classifications. sample.provenance.asset could be assigned to a some specific scope or account with an appropriate value. In order for this to work on metadata scopes the validation logic of the attribute module must be extended to allow this alternate address prefix. The rest of the scope MetadataAddress is already compliant with the required AccAddress expected format.

Proposal

Update the attribute module to allow the scope prefixed addresses to be used for attribute assignment.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added enhancement New feature or request metadata Metadata Module attribute Attribute Module labels Feb 1, 2022
@iramiller iramiller added this to the v1.8.0 milestone Feb 1, 2022
@iramiller iramiller moved this from Todo to In Progress in Provenance Core Protocol Team Feb 1, 2022
Repository owner moved this from In Progress to Done in Provenance Core Protocol Team Feb 2, 2022
@iramiller iramiller moved this from Done to Archive in Provenance Core Protocol Team Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attribute Attribute Module enhancement New feature or request metadata Metadata Module
Projects
Development

Successfully merging a pull request may close this issue.

2 participants