Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture all included protobufs into release zip file #556

Closed
4 tasks done
iramiller opened this issue Nov 10, 2021 · 2 comments · Fixed by #613
Closed
4 tasks done

Capture all included protobufs into release zip file #556

iramiller opened this issue Nov 10, 2021 · 2 comments · Fixed by #613
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@iramiller
Copy link
Member

iramiller commented Nov 10, 2021

Summary

Currently there are some third party dependency protos that are part of data on chain associated with our releases that are not included in our proto zip file release

Problem Definition

By not capturing all of the protos from third party dependencies like wasmd in our proto files clients are required to track down these dependencies when they need to decode this data. This is extra complicated because some of the protos change with the dependency version changes

Proposal

Ensure that all third party dependency protos are copied into the release proto zip file.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added the dependencies Pull requests that update a dependency file label Nov 10, 2021
@ghost
Copy link

ghost commented Nov 10, 2021

Note on this: we want to make sure we use ultimate source of truth on the protos. so cosmos comes from cosmos, ibc comes from ibc, and wasm comes from wasm. Also, pulling ALL protos, not just used protos.

@ghost
Copy link

ghost commented Nov 10, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging a pull request may close this issue.

2 participants