Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scope implementation to metadata module #53

Closed
10 of 14 tasks
iramiller opened this issue Feb 9, 2021 · 0 comments · Fixed by #62
Closed
10 of 14 tasks

Add Scope implementation to metadata module #53

iramiller opened this issue Feb 9, 2021 · 0 comments · Fixed by #62
Assignees
Milestone

Comments

@iramiller
Copy link
Member

iramiller commented Feb 9, 2021

Summary

Implement basic metadata structure for Scope

Problem Definition

  • Review proto message for appropriate identifiers and structure, update as needed
  • Implement ValidateBasic for Scope
  • Add New[Object] functions for creating an instance of Scope
  • Create test suite to cover basic validation logic
  • Implement appropriate Stringer interface method, add test case
  • Create associated keeper file for Scope.
    • Get/Set/Remove methods for object in state store (include events and instrumentation publishing). Ensure remove method fails if there are any existing references to object. Update any indexes that might be useful for rapidly querying/accessing data for queries. Example: all scopes with a given value_owner
    • Stateful validation of object (pull existing, verify any updates are allowed, etc)
    • Implement iterator using KVStorePrefixIterator and appropriate prefix
  • Wire up msg_server and query_server endpoints to new keeper methods.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant