Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct support for UUID names despite name length restriction #48

Closed
4 tasks
iramiller opened this issue Feb 8, 2021 · 1 comment · Fixed by #49
Closed
4 tasks

Ensure correct support for UUID names despite name length restriction #48

iramiller opened this issue Feb 8, 2021 · 1 comment · Fixed by #49
Assignees
Milestone

Comments

@iramiller
Copy link
Member

Summary

Ensure proper support for names in name service based on UUID. See x/name/keeper/keeper_test.go#46

Problem Definition

The name service has a special exemption for uuid based names that bypasses the length restriction. Ensure this capability is maintained, restore the unit test in normalizeName and remove the existing TODO statement.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller
Copy link
Member Author

We should also consider making the default value for number of segments allowed something shorter like 5 or 6 because if these were all or mostly based on uuids then the fully qualified name string would become excessively long. In any case a test should be added that makes every name segment allowed up to some sort of limit a uuid to verify correct operation and behavior.

@channa-figure channa-figure self-assigned this Feb 8, 2021
@channa-figure channa-figure linked a pull request Feb 8, 2021 that will close this issue
@iramiller iramiller added this to the 0.1.4 milestone Feb 23, 2021
@iramiller iramiller moved this from Todo to Done in Provenance Core Protocol Team Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants