Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coin metadata config for nhash #42

Closed
iramiller opened this issue Feb 5, 2021 · 2 comments · Fixed by #60
Closed

coin metadata config for nhash #42

iramiller opened this issue Feb 5, 2021 · 2 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request nice-to-have Features not required in upcoming milestone
Milestone

Comments

@iramiller
Copy link
Member

iramiller commented Feb 5, 2021

Create a coin denom metadata configuration for hash that maps nhash and hash as 1x10^8 nhash, etc. For examples of how the bank module handles denom metadata refer to: https://github.com/cosmos/cosmos-sdk/blob/master/x/bank/types/metadata_test.go

@iramiller iramiller added enhancement New feature or request nice-to-have Features not required in upcoming milestone labels Feb 5, 2021
@iramiller
Copy link
Member Author

We might actually want to put this in the chain somehow ... even if it is just in the local testnets for now. It would be good info for @crussell-figure to refer to for the Explorer project.

{
  "description": "The native staking token of the Provenance Blockchain.",
  "denom_units": [
    {
      "denom": "nhash",
      "exponent": 0,
      "aliases": [
        "nanohash"
      ],
    },
    {
      "denom": "hash",
      "exponent": 9,
    }
  ],
  "base": "nhash",
  "display": "hash",
}
provenanced q bank denom-metadata

I believe the denom metadata endpoints are not currently wired into the rest services in 0.41 of the sdk.

@iramiller
Copy link
Member Author

This is related to #47. It would probably be best to use the Marker Module endpoints for display/setting of denom metadata for integration with the explorer "Asset" pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice-to-have Features not required in upcoming milestone
Projects
Development

Successfully merging a pull request may close this issue.

2 participants