Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module event handler scope #289

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Update module event handler scope #289

merged 3 commits into from
Apr 30, 2021

Conversation

iramiller
Copy link
Member

@iramiller iramiller commented Apr 30, 2021

Description

Updates each modules handler to setup a new event manager scope within the handler function that processes msgs. Modifies unit tests to assert on the response from the handler to check for events.

closes: #288


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #289 (0297f14) into main (0141016) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   50.12%   50.13%   +0.01%     
==========================================
  Files         122      122              
  Lines       11115    11119       +4     
==========================================
+ Hits         5571     5575       +4     
  Misses       4995     4995              
  Partials      549      549              
Impacted Files Coverage Δ
x/attribute/handler.go 83.33% <100.00%> (+1.51%) ⬆️
x/marker/handler.go 76.66% <100.00%> (+0.39%) ⬆️
x/metadata/handler.go 31.66% <100.00%> (+1.15%) ⬆️
x/name/handler.go 66.66% <100.00%> (+1.96%) ⬆️

@iramiller iramiller marked this pull request as ready for review April 30, 2021 14:53
Copy link
Contributor

@channa-figure channa-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@piercetrey-figure piercetrey-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pulled this down and it fixes the issue I was seeing, thanks!

Copy link
Contributor

@dwedul-figure dwedul-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iramiller iramiller merged commit 04aa118 into main Apr 30, 2021
@iramiller iramiller deleted the 288-event-manager-scope branch April 30, 2021 16:29
@iramiller iramiller restored the 288-event-manager-scope branch June 2, 2021 20:12
@iramiller iramiller deleted the 288-event-manager-scope branch June 2, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events being duplicated
4 participants