Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify 'enable governance' behavior on marker module #227

Closed
4 tasks
iramiller opened this issue Apr 7, 2021 · 0 comments · Fixed by #234
Closed
4 tasks

Modify 'enable governance' behavior on marker module #227

iramiller opened this issue Apr 7, 2021 · 0 comments · Fixed by #234
Assignees
Labels
enhancement New feature or request marker Marker Module
Milestone

Comments

@iramiller
Copy link
Member

iramiller commented Apr 7, 2021

Summary

Currently the enable_governance parameter on the marker module is used to enable/disable the use of governance proposals to manage markers. This is not a very useful setting. This issue is for modifying the behavior of this flag to (when enabled) require that all markers added to the system have "enable_governance" set to true.

Problem Definition

This change will ensure that any marker added by any user is subject to the jurisdiction of a stake holder vote.

What problems may be addressed by introducing this feature?

Users that create tokens with invalid permissions or otherwise setup a marker with unintended or malicious behavior will still have a remedy through the use of a governance proposal to address the issue.

What benefits does the Provenance Network stand to gain by including this feature?

The stakeholders of the provenance network will be ensured to have a tool for addressing marker issues.

Are there any disadvantages of including this feature?

Creating a marker that can not be controlled by a governance proposal will not be possible through the normal "add marker" request process but can be addressed using a governance proposal to create the special marker.

Proposal

Update the "add marker" flow to check the enable_governance params flag and if set, also set the allow_governance_control value to true. If enable_governance is set to false then allow the allow_governance_control to be set as desired.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller changed the title Modify 'enable governance Modify 'enable governance' behavior on marker module Apr 7, 2021
@iramiller iramiller added enhancement New feature or request marker Marker Module labels Apr 7, 2021
@iramiller iramiller added this to the 1.1.0 milestone Apr 7, 2021
@channa-figure channa-figure self-assigned this Apr 8, 2021
@iramiller iramiller moved this from Todo to Done in Provenance Core Protocol Team Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request marker Marker Module
Projects
Development

Successfully merging a pull request may close this issue.

2 participants