-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegation Staking Limits #1331
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
==========================================
- Coverage 59.00% 58.93% -0.07%
==========================================
Files 196 197 +1
Lines 24729 24783 +54
==========================================
+ Hits 14591 14606 +15
- Misses 9046 9085 +39
Partials 1092 1092
|
fix int64 size issue in error message
To verify:
Note address:
Note address:
Note the failure message:
Note that this smaller delegation is successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs changelog entry, but looks good.
8c742c8
codecov has dropped a bit |
This is expected... the hooks are not reasonable to unit test due to lack of mock structure (especially given the timeframe on release) which is why there is a manual test case on this issue. Not ideal certainly. |
Description
This PR adds hooks that prevent stake concentration for validators.
closes: #1322
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes