Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI for Sanction Gov Props #1311

Closed
4 tasks
SpicyLemon opened this issue Jan 19, 2023 · 1 comment
Closed
4 tasks

Add CLI for Sanction Gov Props #1311

SpicyLemon opened this issue Jan 19, 2023 · 1 comment
Assignees
Labels
cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK enhancement New feature or request sanction Sanction Module

Comments

@SpicyLemon
Copy link
Contributor

Summary

Add CLI commands for creating and submitting the sanction module's governance proposals.

Problem Definition

The sanction module's governance proposal endpoints don't have any CLI helpers. With gov.v1, adding commands to tx gov is deprecated in favor of tx commands in the respective modules that send a MsgSubmitProposal. These commands weren't in the initial sanction module though.

Proposal

Add commands for each sanction module endpoint under tx sanction ....

  • The commands should create their respective Msg, then wrap it in a MsgSubmitProposal and send that.
  • The authority should be populated automatically. There is no reason to ever have it be something other than the one magic value.
  • There should be a --deposit flag for indicating the amount of deposit to include initially.
  • There should be a --metadata flag for populating the proposal's metadata.
  • If they've been added to the MsgSubmitProposal by the time this issue is addressed, there should also be --title and --description flags for those two proposal fields.
  • The sanction and unsanction commands should just take in the list of addresses.
  • The update params command should take in the two coins amounts.
  • The help text for each should indicate that it's submitting a governance proposal.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@SpicyLemon SpicyLemon added enhancement New feature or request cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK sanction Sanction Module labels Jan 19, 2023
@nullpointer0x00 nullpointer0x00 self-assigned this Mar 24, 2023
@nullpointer0x00
Copy link
Contributor

This was completed with PR provenance-io/cosmos-sdk#510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK enhancement New feature or request sanction Sanction Module
Projects
Development

No branches or pull requests

2 participants