Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport MsgExec validate basic call from cosmos-sdk #1303

Closed
4 tasks
nullpointer0x00 opened this issue Jan 12, 2023 · 2 comments
Closed
4 tasks

Backport MsgExec validate basic call from cosmos-sdk #1303

nullpointer0x00 opened this issue Jan 12, 2023 · 2 comments
Assignees
Labels
authz cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK
Milestone

Comments

@nullpointer0x00
Copy link
Contributor

nullpointer0x00 commented Jan 12, 2023

Summary

Authz's MsgExec msgs are not executing ValidateBasic on sub-msgs that are executed. The cosmos team has fixed this but it is not in the v0.46.x releases. cosmos-sdk/pull/12184

Problem Definition

The problem with this is that the Authz msgs are not being validated. This could be problematic as msgs go through their module's msg_server where ValidateBasic is assumed to already have been called before reaching that point.

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@nullpointer0x00 nullpointer0x00 added authz cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK labels Jan 12, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.14.0 milestone Jan 12, 2023
@nullpointer0x00 nullpointer0x00 self-assigned this Jan 12, 2023
@nullpointer0x00 nullpointer0x00 moved this from Todo to In Progress in Provenance Core Protocol Team Jan 13, 2023
@nullpointer0x00
Copy link
Contributor Author

This has been updated on the provenance cosmos-sdk fork. It is currently on the https://github.com/provenance-io/cosmos-sdk/tree/release-pio/v0.46.x and this will need to be added to the mod.go once it is tagged. We will wait until we know if the sanction and quarantine modules will be included in v1.14.0

@iramiller
Copy link
Member

We will wait until we know if the sanction and quarantine modules will be included in v1.14.0

These are headline features for the next release imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authz cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK
Projects
Development

No branches or pull requests

3 participants