Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConversionFeeDenom param missing from GetParams in MsgFees module. #1214

Closed
4 tasks
nullpointer0x00 opened this issue Nov 7, 2022 · 0 comments · Fixed by #1215
Closed
4 tasks

ConversionFeeDenom param missing from GetParams in MsgFees module. #1214

nullpointer0x00 opened this issue Nov 7, 2022 · 0 comments · Fixed by #1215
Assignees
Labels
msgfees Msg based fee module
Milestone

Comments

@nullpointer0x00
Copy link
Contributor

Summary of Bug

The ConversionFeeDenom is missing in the GetParams() method of the msgfees module.

Currently:

// GetParams returns the total set of distribution parameters.
func (k Keeper) GetParams(ctx sdk.Context) (params types.Params) {
	return types.Params{
		FloorGasPrice:  k.GetFloorGasPrice(ctx),
		NhashPerUsdMil: k.GetNhashPerUsdMil(ctx),
	}
}

Required:

// GetParams returns the total set of distribution parameters.
func (k Keeper) GetParams(ctx sdk.Context) (params types.Params) {
	return types.Params{
		FloorGasPrice:  k.GetFloorGasPrice(ctx),
		NhashPerUsdMil: k.GetNhashPerUsdMil(ctx),
		ConversionFeeDenom: k.GetConversionFeeDenom(ctx),
	}
}

Version

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msgfees Msg based fee module
Projects
Development

Successfully merging a pull request may close this issue.

1 participant