You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
so proposed fix is to set this value to baseFeeToConsume.String( initially but to swap it out to total fee charged value
if the runMsgs is a success, will require changes to baseapp.go to do that.
We also need to emit the suppressed sdk SendCoin events from the FeeInvoker distribution of funds. These include the rollup of fees to the FeeModule and Recipients of msgfees and event for the Swept Fee amount.
Version
v.1.12 (current production)
Steps to Reproduce
Send a tx which will fail, fee charged will be only the min_fee_charged event but fee event will be whatever is sent in.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary of Bug
Make the
fee
event correct before v1.13 goes to prod.Currently
Which is correct in case of
success
But in failure case, this is not right because the fee charged is only the
so proposed fix is to set this value to
baseFeeToConsume.String(
initially but to swap it out tototal fee charged
valueif the
runMsgs
is asuccess
, will require changes tobaseapp.go
to do that.We also need to emit the suppressed sdk
SendCoin
events from the FeeInvoker distribution of funds. These include the rollup of fees to the FeeModule and Recipients of msgfees and event for the Swept Fee amount.Version
v.1.12 (current production)
Steps to Reproduce
Send a tx which will fail, fee charged will be only the
min_fee_charged
event butfee
event will be whatever is sent in.For Admin Use
The text was updated successfully, but these errors were encountered: