Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make helm Ingress compatible with k8s v1.22+ #1337

Closed
bahaeddinoz opened this issue Dec 29, 2021 · 4 comments · Fixed by #1340
Closed

Make helm Ingress compatible with k8s v1.22+ #1337

bahaeddinoz opened this issue Dec 29, 2021 · 4 comments · Fixed by #1340
Assignees
Labels
scope/infrastructure CI / Dev. Env scope/k8s K8s or helm stuff (really annoying) type/enhancement En enhancement to an already existing feature
Milestone

Comments

@bahaeddinoz
Copy link

Is your proposal related to a problem?

Can we change the ingress to make compatiable with k8s v1.22+

(Write your answer here.)

Describe the solution you'd like

Can we change the ingress to make compatiable with k8s v1.22+

(Describe your proposed solution here.)

Describe alternatives you've considered

(Write your answer here.)

Additional context

(Write your answer here.)

@bahaeddinoz bahaeddinoz added the type/enhancement En enhancement to an already existing feature label Dec 29, 2021
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Dec 29, 2021
@github-actions
Copy link

Hello there bahaeddinoz! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

@Haarolean
Copy link
Contributor

Hey, thanks for reaching out. We'll take a look.

@Haarolean Haarolean added scope/k8s K8s or helm stuff (really annoying) scope/infrastructure CI / Dev. Env and removed status/triage Issues pending maintainers triage labels Dec 29, 2021
@Haarolean Haarolean added this to the 0.3.1 milestone Dec 29, 2021
@Haarolean Haarolean changed the title helm Ingress is deprecated Make helm Ingress compatible with k8s v1.22+ Dec 29, 2021
@bahaeddinoz
Copy link
Author

Thanks @Haarolean for the so quick updates 🙏 Just one question why directly didn't we use the "networking.k8s.io/v1 " and instead specified if k8s version is highter then 1.22 ? k8s supports it since v1.10. Can be good to use it directly or is there any other reason ?
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#apiservice-v122

@Haarolean
Copy link
Contributor

@bahaeddinoz first of all, your documentation says it's supported since 1.19, not 1.10 (Migrate manifests and API clients to use the networking.k8s.io/v1 API version, available since v1.19.). The main purpose is to save back compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infrastructure CI / Dev. Env scope/k8s K8s or helm stuff (really annoying) type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants