From 008a9afd3a61e70f8c5549a6adfcd543ab5a9f27 Mon Sep 17 00:00:00 2001 From: Mike Kruskal Date: Wed, 1 Feb 2023 08:04:27 -0800 Subject: [PATCH] Explicitly drop support for python on Windows. This was already broken, but wasn't caught in tests because `python3` wasn't defined on our windows machines. To prevent it from breaking the entire downstream Bazel workspace when `python3` exists, we mark it unsupported. PiperOrigin-RevId: 506318286 --- bazel/system_python.bzl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bazel/system_python.bzl b/bazel/system_python.bzl index 2979c14dcd..5cb34d5ffd 100644 --- a/bazel/system_python.bzl +++ b/bazel/system_python.bzl @@ -195,6 +195,10 @@ def _populate_package(ctx, path, python3, python_version): if int(python_version[idx]) < int(v): supported = False break + if "win" in ctx.os.name: + # buildifier: disable=print + print("WARNING: python is not supported on Windows") + supported = False build_file = _build_file.format( interpreter = python3,