-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing php 8.1 deprecation warnings #9370
Merged
haberman
merged 13 commits into
protocolbuffers:master
from
brettmc:bugfix/php-8.1-deprecations
Feb 2, 2022
Merged
fixing php 8.1 deprecation warnings #9370
haberman
merged 13 commits into
protocolbuffers:master
from
brettmc:bugfix/php-8.1-deprecations
Feb 2, 2022
Commits on Jan 5, 2022
-
fixing php 8.1 deprecation warnings
php 8.1 is more strict, and raises some deprecation notices with existing protobuf code. Not all of the deprecations can be fixed without dropping support for php7.x (eg, the 'mixed' type doesn't appear until 8.1, and union types until 8.0, but as an interim solution the 'ReturnTypeWillChange' attribute can be used to suppress the notices. In passing, also be explicit about a cast from float to int in 'zigZagEncode64' which 8.1 also complains about when running tests.
Configuration menu - View commit details
-
Copy full SHA for c26b1c8 - Browse repository at this point
Copy the full SHA c26b1c8View commit details
Commits on Jan 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fabe73d - Browse repository at this point
Copy the full SHA fabe73dView commit details
Commits on Jan 10, 2022
-
bcmath (specifically, the bccomp function) is internally required, and tests fail if it's not available
Configuration menu - View commit details
-
Copy full SHA for 558d128 - Browse repository at this point
Copy the full SHA 558d128View commit details
Commits on Jan 13, 2022
-
conditionally adding mixed return type
With guidance from Remi Collet, use ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_EX macro, and use a conditional to fake that macro for earlier php versions. Tested on 8.1 and 7.4, and deprecation notices gone plus all tests pass
Configuration menu - View commit details
-
Copy full SHA for 0476a89 - Browse repository at this point
Copy the full SHA 0476a89View commit details -
bump extension min version to 7.2
The macro ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX changed in 7.2, so it cannot be used in a compatible way with earlier versions
Configuration menu - View commit details
-
Copy full SHA for 9e65df2 - Browse repository at this point
Copy the full SHA 9e65df2View commit details
Commits on Jan 19, 2022
-
instead of using the void return type, add more ReturnTypeWillChange annotations
Configuration menu - View commit details
-
Copy full SHA for bfe33d7 - Browse repository at this point
Copy the full SHA bfe33d7View commit details
Commits on Jan 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f689268 - Browse repository at this point
Copy the full SHA f689268View commit details -
Configuration menu - View commit details
-
Copy full SHA for c62cbe9 - Browse repository at this point
Copy the full SHA c62cbe9View commit details
Commits on Jan 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 110d6c1 - Browse repository at this point
Copy the full SHA 110d6c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a3f384 - Browse repository at this point
Copy the full SHA 6a3f384View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e724d8 - Browse repository at this point
Copy the full SHA 3e724d8View commit details
Commits on Jan 25, 2022
-
I think it _should_ be required, but a test (linux, 32bit, 7.0-zts) is choking on composer install, so putting things back to how I found them
Configuration menu - View commit details
-
Copy full SHA for a78b89e - Browse repository at this point
Copy the full SHA a78b89eView commit details
Commits on Jan 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4c03fcf - Browse repository at this point
Copy the full SHA 4c03fcfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.