Include JRuby gem when building gem:native target #8954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is the rake target used by kokoro, this will close the gem release gap for JRuby Should help protocolbuffers#7923 by making sure JRuby is built and released as part of the normal cadence.
|
@acozzette - could you rerun the kokoro tests with the second commit included? |
perezd
reviewed
Sep 7, 2021
| @@ -95,7 +97,18 @@ else | |||
| ] | |||
| end | |||
|
|
|||
| task 'gem:java' do | |||
There was a problem hiding this comment.
ulta nit: should this be jruby to be more clear?
There was a problem hiding this comment.
I was inclined to align with the terminology used in the Gemfile but I don't feel strongly about it.
There was a problem hiding this comment.
sure thing, was just thinking about future travelers that are reading this, what does "java" mean vs jruby is a clearer target, at least for me.
There was a problem hiding this comment.
@haberman / @acozzette - any preference between gem:java vs gem:jruby?
|
Obviated by #9047 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is the rake target used by kokoro, this will close the gem release gap for JRuby
Should help #7923 by making sure JRuby is built and released as part of the normal cadence.