Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Make libprotobuf symbols local on OSX" - fix missing #9395

Closed
peteboothroyd opened this issue Jan 10, 2022 · 2 comments
Closed

"Make libprotobuf symbols local on OSX" - fix missing #9395

peteboothroyd opened this issue Jan 10, 2022 · 2 comments
Assignees

Comments

@peteboothroyd
Copy link

The initial problem is described here. The current issue is that a piper import issue has caused the fix to be removed, meaning that the problem has been reintroduced. The import issue is discussed further here. This issue is opened to track the reintroduction of the fix.

Perhaps part of the issue is that there wasn't an associated test added to verify that only a limited subset of all the available symbols were exposed in the resulting dylib. I'm not sure how/if this is possible in the current wheel building pipeline.

What version of protobuf and what language are you using?
Version: All versions as far as I know.
Language: Python

What operating system (Linux, Windows, ...) and version? macOS

What did you expect to see

The fix introduced in #8346 should be present in the setup.py file.

What did you see instead?

The fix has been removed.

@deannagarcia
Copy link
Member

Closing the issue since the PR is merged, but feel free to open again if you still see the problem.

@alalek
Copy link

alalek commented Jan 28, 2022

FYI, the similar problem of "all global" symbols on Linux: #3899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants