Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nullptr used in 3.5.1 #4094

Closed
jakirkham opened this issue Dec 23, 2017 · 5 comments
Closed

nullptr used in 3.5.1 #4094

jakirkham opened this issue Dec 23, 2017 · 5 comments

Comments

@jakirkham
Copy link

Appears that nullptr is used in 3.5.1 as evidenced by this build failure. nullptr requires C++11 at least.
@jakirkham jakirkham mentioned this issue Dec 23, 2017
Merged
@jakirkham
Copy link
Author

For reference, nullptr shows up on this line. This was introduced by PR ( #4013 ). So cc-ing @laszlocsomor.

@jakirkham jakirkham mentioned this issue Dec 29, 2017
Closed
@laszlocsomor
Copy link
Contributor

Thanks for letting me know! That PR (#4013) isn't yet merged to master, so the line doesn't exist on master yet.
@pherl , shall I send PR to merge it to master?

@liujisi
Copy link
Contributor

liujisi commented Jan 2, 2018

Master is now c++11 only. We only need to fix it in the 3.5.x branch.

@liujisi liujisi mentioned this issue Jan 2, 2018
Merged
@laszlocsomor
Copy link
Contributor

@pherl : Thanks! So shall I create a PR to merge that commit to master, or will you (or someone else) merge all 3.5.x changes back to master?

@liujisi
Copy link
Contributor

liujisi commented Jan 3, 2018

I will merge it back.

@liujisi liujisi closed this as completed Jan 3, 2018
@pnrobinson pnrobinson mentioned this issue May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liujisi @jakirkham @laszlocsomor