Ensure that referenced classes contain full namespace. #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a complete namespace to classes referenced by the generated Protobuf ruby classes.
eg.
Protobuf::Test::Beta
vsBeta
Referencing the class with its full namespace is needed when using autoloading and the implementers code contains a pre-existing class with the same name as the class referenced within the protobuf.
Here's a very basic example.
If the Protobuf references another Protobuf class which has the same name as an existing class, load order takes precedence. Even when the existing class is in another namespace. This leads to the Protobuf referencing
Beta
vsProtobuf::Test::Beta
When other classes are not loaded first, the Protobuf references the correct class.