Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select: selectionChange should also emit item in id mode #91

Open
saithis opened this issue May 26, 2020 · 1 comment
Open

select: selectionChange should also emit item in id mode #91

saithis opened this issue May 26, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@saithis
Copy link
Collaborator

saithis commented May 26, 2020

No description provided.

@Yirica
Copy link
Contributor

Yirica commented Jun 10, 2020

Looked into this for a short while. My impressions:

  • With the current usage of mat-select selectionChange, the item would have to be loaded from the dataSource. Can't estimate the workload of this solution.

  • Another option is to use onSelectionChange of mat-option and emit it from select-data.component to select.component. This makes it easy to access the item of the option in the change event. But this event triggers quite often on a single change. Restricting the emit by the provided "isUserInput" doesn't seem correct.

  • Adding the item to the value in id mode doesn't seem like the way to go either.

@saithis saithis added the enhancement New feature or request label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants