Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow metrics with inconsistent label dimensions #179

Closed
vsakhart opened this issue Jan 15, 2019 · 1 comment
Closed

Allow metrics with inconsistent label dimensions #179

vsakhart opened this issue Jan 15, 2019 · 1 comment

Comments

@vsakhart
Copy link

Hello,

Currently if you try to update a metric with a labelset that is inconsistent with whats registered, the metric gets dropped. As of release 0.9 of the Prometheus Go client, specifically 417, inconsistent label dimensions are now allowed.

One way to mitigate this issue is to restart the exporter on code changes but the exporter will still drop metrics if two different code paths try to update a metric with different label dimensions. Ideally the statsd exporter can handle this case and doesn't drop any metrics.

@matthiasr
Copy link
Contributor

I agree, since it's officially allowed now we should support it. I'm going to close this issue and add the information to #114, since that has more history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants