From f1760bd818ed62425ba30dd601372cf84ef766da Mon Sep 17 00:00:00 2001 From: David Ashpole Date: Tue, 26 Nov 2024 03:33:15 +0000 Subject: [PATCH] preserve existing behavior for PromQL operations Signed-off-by: David Ashpole --- proposals/2024-09-25_metadata-labels.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/proposals/2024-09-25_metadata-labels.md b/proposals/2024-09-25_metadata-labels.md index 2166074..b81dacb 100644 --- a/proposals/2024-09-25_metadata-labels.md +++ b/proposals/2024-09-25_metadata-labels.md @@ -64,6 +64,8 @@ Users see no difference to exposition formats. When a query for a metric returns multiple metrics with a different `__type__` or `__unit__` label, but the same `__name__`, an info annotation will be returned with the PromQL response, which is otherwise unmodified. +Aggregations and label matches ignore `__unit__` and `__type__` and any operation would remove the `__unit__` and `__type__` label (with the exception of label_replace). + ### Prometheus UI Changes When displaying a metric's labels in the table or in the graph views, the UI will hide labels starting with `__` (double underscore) by default, similar to the current handling of `__name__`. A "Show System Labels" check-box will be added, which shows hidden labels when checked.