Rename choose_formatter back to choose_encoder #796
Conversation
csmarchbanks
force-pushed
the
revert-unintentional-breaking-change
branch
2 times, most recently
from
502de1c
to
9492b5e
Compare
|
Note that this renaming is again a breaking change. If you want to avoid it, you could define one of the names as an alias to the other to get backwards-compatibility with the prior versions and 0.14 (though that's obviously ugly) |
1 similar comment
|
Note that this renaming is again a breaking change. If you want to avoid it, you could define one of the names as an alias to the other to get backwards-compatibility with the prior versions and 0.14 (though that's obviously ugly) |
|
Yeah, that is the case and I would prefer not to maintain the second function name forever. I am hoping that most people who are pinning versions are either pinning both or will upgrade to the patch version fairly quickly. Since the release has only been out for three days a bugfix to revert to the previous behavior seems reasonable to me? |
csmarchbanks
force-pushed
the
revert-unintentional-breaking-change
branch
3 times, most recently
from
a7c476d
to
aeeb5d2
Compare
|
To avoid the second breaking change in 0.14.x I added choose_formatter back in with a deprecation notice. It will be removed as part of 0.15, but that at least gives everyone some time to use either. |
Temporarily keep an alias so that choose_formatter will work for the 0.14.x release cycle. Signed-off-by: Chris Marchbanks <[email protected]>
csmarchbanks
force-pushed
the
revert-unintentional-breaking-change
branch
from
aeeb5d2
to
ff2e7a4
Compare
Other libraries depend on this function and we did not mean to create a breaking change. Add a test to document that this is part of the API.
Fixes #795