Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.10 #706

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 13, 2021

Python 3.10 was released last week:

We can also remove some redundant Python 2.6 code.

Signed-off-by: Hugo van Kemenade <[email protected]>
Signed-off-by: Hugo van Kemenade <[email protected]>
Signed-off-by: Hugo van Kemenade <[email protected]>
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for both the 3.10 addition and 2.6 cleanup!

@csmarchbanks csmarchbanks merged commit 6650d07 into prometheus:master Oct 29, 2021
@hugovk hugovk deleted the add-3.10 branch October 29, 2021 15:55
@hugovk
Copy link
Contributor Author

hugovk commented Oct 29, 2021

You're welcome! It might be time to start thinking about dropping EOL 2.7-3.5, they have low download numbers.

Here's the pip installs for prometheus_client from PyPI for September 2021:

category percent downloads
3.7 67.13% 16,924,029
3.8 17.88% 4,508,113
3.6 8.32% 2,096,751
3.9 3.04% 767,182
2.7 1.64% 412,758
null 1.57% 396,362
3.5 0.40% 101,217
3.10 0.01% 2,544
3.4 0.00% 372
3.3 0.00% 8
3.11 0.00% 2
Total 25,209,338

Source:

pip install -U pypistats
pypistats python_minor prometheus_client --last-month

@csmarchbanks
Copy link
Member

Yep, I have been thinking about EOL for 2 as well. Last time I had pulled numbers was in February, which had closer to 5% usage: #535 (comment). Usage dropping below 2% certainly makes deprecation seem reasonable (as well as more and more projects and AWS discontinuing support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants