Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark_process_dead respects old env var #644

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

csmarchbanks
Copy link
Member

Some users use mark_process_dead without going through any of the
__init__() logic which sets the new environment variable.

I chose not to put in the warnings in another place as a user will go
through the deprecation path somewhere already.

Fixes #643

leohemsted added a commit to alphagov/notifications-admin that referenced this pull request Apr 8, 2021
we saw exceptions on prod that I think might have caused a worker that
is being terminated to die ungracefully. While I'm not sure if this is
an actual problem that changed behaviour (app instances crashing and
restarting), at the very least it definitely polluted the logs and
obscured any actual issues we were having.

https://github.com/prometheus/client_python/releases/tag/v0.10.0

see the pending fix for this problem here:
prometheus/client_python#644
Some users use mark_process_dead without going through any of the
__init__() logic which sets the new environment variable.

Signed-off-by: Chris Marchbanks <[email protected]>
@csmarchbanks csmarchbanks force-pushed the fix-mark_process_dead-old-env-var branch from 1d68ee7 to 9d745ed Compare April 8, 2021 15:56
Copy link

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csmarchbanks csmarchbanks merged commit 84f526b into master Apr 8, 2021
@csmarchbanks csmarchbanks deleted the fix-mark_process_dead-old-env-var branch April 8, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with prometheus_multiproc_dir deprecation
2 participants