Fix twisted test on Python3.4 #427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf twisted/twisted@fc3be69 and twisted/twisted@8a47339 broke Python3.4 between 19.2.0 and 19.2.1 Signed-off-by: Xavier Fernandez <[email protected]>
xavfernandez
force-pushed
the
xfernandez/fix_twisted_34
branch
from
acd1116
to
4360a9d
Compare
|
cc @brian-brazil (with #424) |
|
This fixes the failing test of master branch: https://travis-ci.org/prometheus/client_python/builds/542696662 |
tox.ini
Outdated
| @@ -29,7 +29,8 @@ deps = | |||
| [testenv] | |||
| deps = | |||
| {[base]deps} | |||
| {py27,py34,py35,py36,pypy,pypy3}: twisted | |||
| {py27,py35,py36,pypy,pypy3}: twisted | |||
| {py34}: twisted==19.2.1 | |||
There was a problem hiding this comment.
We're only meant to test everything on the latest of each minor version, so you can drop 3.4 and 3.5
There was a problem hiding this comment.
Is #428 what you meant ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf
twisted/twisted@fc3be69
and twisted/twisted@8a47339 broke Python3.4 between 19.2.0 and 19.2.1
Signed-off-by: Xavier Fernandez [email protected]