-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset counter #1005
Reset counter #1005
Conversation
Signed-off-by: Paul Melnikov <[email protected]>
Signed-off-by: Paul Melnikov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One small comment, and would you be willing to add a test as well please?
Co-authored-by: Chris Marchbanks <[email protected]> Signed-off-by: Paul Melnikov <[email protected]>
I'll see what I can about the test! |
@csmarchbanks do we need a test for "created" sample? I'm not entirely sure how to test that, as it's tied to system time |
Ideally yes, I would say just make sure that the value for |
Signed-off-by: Paul Melnikov <[email protected]>
466a224
to
2114b1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adds
.reset()
method to Counter metric.Closes #995.