-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please return thread from start_http_server #883
Comments
I think I would be ok with this but will give a bit of time for others to chime in as well. My only initial concern would be that it would make it a bit harder to change an internal implementation, but that is fairly minor. |
I was thinking about this. How do I shut down the serving component? I guess I don't and just shutdown the application. |
Correct, |
I am in favor of a way to control with the thing created. Having a start_http_server not returning a handle is like a copy command that copies files but doesn't tell you where it put the file copy and now it's a game of hide and seek. ;-) |
We would also like to have that, see issue #983. |
#999 will implement this. It returns the server as well as the thread to allow shutdowns, happy to hear any comments about that and will otherwise merge it soon. |
Similar to #314, but less invasive, IMHO.
I often wrap APIs with a small layer of Python to turn metrics into something that Prometheus can ingest. Rather than adding
while True: sleep(1)
or similar at the end of my scripts I would like to do this:The text was updated successfully, but these errors were encountered: