Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus-metrics-exposition-formats] Consider making protobuf optional #1173

Open
AB-xdev opened this issue Oct 22, 2024 · 5 comments · May be fixed by #1190
Open

[prometheus-metrics-exposition-formats] Consider making protobuf optional #1173

AB-xdev opened this issue Oct 22, 2024 · 5 comments · May be fixed by #1190

Comments

@AB-xdev
Copy link

AB-xdev commented Oct 22, 2024

Context:
I'm using Spring Boot and as metrics implementation for actuator micrometer-registry-prometheus which then uses prometheus-metrics-exposition-formats

While inspecting our final built jar I noticed that your dependency is shipped with protobuf which is rather big (when compared to the rest):

I'm also not actively using protobuf and therefore it would be great if this could somehow be excluded.

It's also noted in the docs that protobuf is somewhat obsolete/experimental so shipping this by default is maybe not needed in the first place.
@AB-xdev
Copy link
Author

AB-xdev commented Oct 22, 2024

Another extrem good example why it's not wise to ship all dependencies (that are likely barely used) by default and use a more modulare approach:
GHSA-735f-pc8j-v9w8

@AB-xdev
Copy link
Author

AB-xdev commented Oct 23, 2024

For now we create a "workaround" project: https://github.com/xdev-software/prometheus-metrics-exposition-formats-no-protobuf

@AB-xdev
Copy link
Author

AB-xdev commented Oct 23, 2024 •
edited
Loading

Also:
In c9bb30b protobuf is now directly shaded into prometheus-metrics-exposition-formats and it can no longer be ignored -.-
I think it would be good to revert this.

@AB-xdev
Copy link
Author

AB-xdev commented Oct 23, 2024

Overview:

@AB-xdev AB-xdev mentioned this issue Oct 23, 2024
Open
@fstab
Copy link
Member

fstab commented Oct 28, 2024

Thanks for reporting. Just a quick heads-up: @zeitlinger is the best person to answer this, but he's out this week, so it will likely take until next week before we can respond.

@zeitlinger zeitlinger linked a pull request Nov 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make Protobuf optional prometheus/client_java
2 participants
@fstab @AB-xdev