Use Perflib for logical_disk exporter #400
Conversation
collector/logical_disk.go
Outdated
| @@ -171,26 +170,25 @@ func (c *LogicalDiskCollector) Collect(ctx *ScrapeContext, ch chan<- prometheus. | |||
| // - https://msdn.microsoft.com/en-us/library/ms803973.aspx - LogicalDisk object reference | |||
| type Win32_PerfRawData_PerfDisk_LogicalDisk struct { | |||
There was a problem hiding this comment.
Bit of a nitpick, but now that we don't use WMI here, we don't need to have the type name match the WMI class name. We also don't need to export the type, so perhaps change to just logicalDisk?
There was a problem hiding this comment.
Yes, better to clean it up now then to leave others wondering at the type name in the future.
Are you happy to leave the documentation link for the type?
There was a problem hiding this comment.
I think the doc link still looked relevant, but I didn't look super closely, is there something off with it?
There was a problem hiding this comment.
Not at all. My preference would be to leave it in, as it is still largely relevant for the perflib metrics. Just checking.
There was a problem hiding this comment.
Type has been renamed to logicalDisk. I've rebased the commits and force pushed them to my branch.
Latency metrics were previously exposing as ticks
|
LGTM, thanks! |
Use Perflib for logical_disk exporter
PR modifies the logical_disk exporter to use Perflib in place of WMI. The PR also fixes value format for several latency metrics (ticks -> seconds).
However, perflib is reporting
% Free Spaceas the number of free megabytes (identical toFree Megabytes), breaking theTotalSpacemetric.I've opened an issue in the perflib_exporter repository regarding this: leoluk/perflib_exporter/issues/23