Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to windows_exporter, move to prometheus-community #519

Closed
8 tasks done
carlpett opened this issue May 9, 2020 · 11 comments
Closed
8 tasks done

Rename to windows_exporter, move to prometheus-community #519

carlpett opened this issue May 9, 2020 · 11 comments

Comments

@carlpett
Copy link
Collaborator

carlpett commented May 9, 2020

As decided in #499, we will rename the exporter to windows_exporter. This issue tracks the required changes.
After these steps are completed, we will be ready to move the repo to the prometheus-community organization 🎉

  • Change metric namespace (collector.go).
  • Change textfile collector defaults.
  • Change Go module name.
  • Update build automation.
  • Change the installer.
  • Update contrib/console_templates.
  • Update docs.
  • Rename repo.
@Mario-Hofstaetter
Copy link
Contributor

This there an ETA on this to prepare for?
Since renaming the metrics is quite the breaking change and we are just rolling out the exporter and dashboards.

@carlpett
Copy link
Collaborator Author

Hey @Mario-Hofstaetter,
Very good question! There's a bunch of unreleased changes on master (three new collectors!), so I will make sure that is released as 0.12. Then hopefully do the move within the next week, workload permitting.
I have prepared most of the changes, but ran out of time to validate them. Especially the installer requires a bit of care.

If you want to prepare your environment, you could actually set up a metric relabeling in the Prometheus server to switch the metric namespace already with the current versions. Something like this:

  - job_name: windows
    static_configs:
    - targets: ['localhost:9182']
    metric_relabel_configs:
    - source_labels: ['__name__']
      target_label: '__name__'
      regex: 'wmi_(.*)'
      replacement: 'windows_$1'

@andrewmostello
Copy link
Contributor

On the Chocolatey front, I've created a new package with the new name: prometheus-windows-exporter.install. That's usable now with v0.12.0 to smooth the transition.

0.12 will be the last release pushed to prometheus-wmi-exporter.install. After the name change, I'll deprecate that package according to the Chocolatey guidelines here: Deprecate a Package. All updates will then go to the new package.

If any issues arise, please let me know and I'll address them.

I've also renamed the repository with the Chocolatey scripts. That's now here: prometheus-windows-exporter.install.

@carlpett
Copy link
Collaborator Author

carlpett commented Jun 1, 2020

Thanks @andrewmostello!
The rename+move is now done, we just need to sort our CI and then we'll publish a new release.

@carlpett carlpett pinned this issue Jun 1, 2020
@andrewmostello
Copy link
Contributor

Great - sounds good!

@carlpett
Copy link
Collaborator Author

carlpett commented Jun 2, 2020

There's a 0.13 release pushed now, marked as pre-release. Please give it a spin!

@Mario-Hofstaetter
Copy link
Contributor

@carlpett Will final release be 1.0 to reflect the breaking change? Seems more suiting than 0.13.

@carlpett
Copy link
Collaborator Author

carlpett commented Jun 4, 2020

@Mario-Hofstaetter We have a discussion in #537 about the road to 1.0. In short, there's some additional cleanup I'd like to get done which would otherwise require a major version bump, but after that, it's time for 1.0.

@Zayan1221

This comment has been minimized.

@sunilgks
Copy link

How do I configure exporter to extract MS SQL server metrics?

@carlpett
Copy link
Collaborator Author

Since this issue appears to draw generic usage questions, I'll lock this. If you need help with how to use Prometheus or exporters in general, please see the Community resources.

@prometheus-community prometheus-community locked and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants