mssql databases child collector fails in v0.30.0-rc.2

[aa-matthias]

Current Behavior

windows_mssql_collector_success{collector="databases",mssql_instance="MSSQLSERVER"} 0

having set log level to debug via config.yaml but nothing showing up in the eventlog currently.

Expected Behavior

scrape should be successful

Steps To Reproduce

No response

Environment

• windows_exporter Version: v0.30.0-rc.2
• Windows Server Version: 2019 / MSSQL 14.0.3485.1

windows_exporter logs

-

Anything else?

No response

[jkroepke]

windows_mssql_collector_success{collector="databases",mssql_instance="MSSQLSERVER"} 1
windows_mssql_collector_success{collector="databases",mssql_instance="SQLTE2"} 1

I can't verify that on my dev machine.

Idk, if there is an issue with the event log. Bug I would appricate if you could run the export from cmd.exe with --log.level=DEBUG

[aa-matthias]

🤔 i'm getting this:

2024/12/01 08:08:31 ERROR Failed to parse CLI args err="unrecognized log level DEBUG"

[jkroepke]

Ah, lowercase debug is correct.

[aa-matthias]

time=2024-12-01T12:22:16.057+01:00 level=DEBUG source=mssql.go:370 msg="detected MSSQL Instances: mssql.mssqlInstancesType{\"MSSQLSERVER\":\"MSSQL14.MSSQLSERVER\"}\n" collector=mssql
time=2024-12-01T12:22:16.804+01:00 level=WARN source=main.go:210 msg="couldn't initialize collector" err="error build collector mssql: failed to build databases collector: failed to create Databases collector for instance MSSQLSERVER: failed to initialize collector: failed to add counter \\SQLServer:Databases(*)\\Active parallel redo threads: Der angegebene Leistungsindikator wurde nicht gefunden.\r\n"
...
time=2024-12-01T12:22:38.470+01:00 level=DEBUG source=mssql.go:413 msg="mssql class collector databases for instance MSSQLSERVER failed after 511.1µs" collector=mssql err="failed to collect SQLServer:Databases metrics: performance counter not initialized"

before upgrading to 0.30.0-rc.2 (0.29.2) I have received 0 as value for this metric / field via prometheus.

I also cannot find the metric within C:\Program Files\Microsoft SQL Server\MSSQL14.MSSQLSERVER\MSSQL\Binn\perf-MSSQLSERVERsqlctr.ini or via

SELECT * FROM sys.dm_os_performance_counters
WHERE object_name LIKE '%Databases%' order by counter_name;

[jkroepke]

C:\Program Files\Microsoft SQL Server\MSSQL14

SQL Server 2017?

Looking at microsoft/DiagManager#41, it sound like the Counter are available since SQL Server 2019.

0.29.0 just ignores the existence of counter and reports always 0. However, I feel that leads to wrong assumptions to end users.

Instead fail, I would omit the counters on lower versions.

[aa-matthias]

I do agree that omitting them would be the preferred way to handle that.

Wonder why they are listed in the SQL Server Docs for 2016 but that seems to be a doc issue then.

https://learn.microsoft.com/en-us/sql/relational-databases/performance-monitor/sql-server-databases-object?view=sql-server-2016

[jkroepke]

Should be fixed in a upcoming release.

You could also try an snapshot build to verify that: https://github.com/prometheus-community/windows_exporter/actions/runs/12107522322/artifacts/2258517864

[aa-matthias]

Hey - thanks addressing all the findings so quickly! tested the snapshot built successfully!