Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change service location in frontend, another upload script #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elsaperelli
Copy link
Contributor

Summary

This PR changes the service location URL in the frontend app to no longer have the /metadata endpoint. It also adds a new db option: loadPublishableContent. This essentially does the same thing as loadBundle (takes a measure bundle or directory of measure bundles and uploads them to the measure repository service); however, the one difference is that if there are any draft artifacts in the measure, they will be coerced to active so they can be uploaded without error.

New behavior

  • npm run db:loadPublishableContent script

Code changes

  • README.md - additions regarding new db upload option
  • package.json - npm run db:loadPublishableContent
  • app/src/pages/index.tsx - remove /metadata
  • service/scripts/dbSetup.ts - loadPublishableContent now allows measure bundle and measure bundle directory upload while coercing artifacts to active

Testing guidance

  • cd service
  • npm run db:reset
  • npm run db:loadContentBundle <path to one of the bundles where Measure has status draft>
  • cd ..
  • npm run start:all
  • Make sure Measure has been uploaded with status active
  • Check Service Location URL in frontend

Copy link
Contributor

@lmd59 lmd59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts to having this script load the environment variable and do this publishable coercion based on that rather than the script name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants