Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Check on Invocation #414

Open
tobru opened this issue Feb 11, 2022 · 1 comment
Open

Version Check on Invocation #414

tobru opened this issue Feb 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tobru
Copy link
Contributor

tobru commented Feb 11, 2022

Context

I observed that users are many times running an outdated version of Commodore. We should add a check on invocation which checks if the installed version of Commodore is up-to-date. This check should be configurable, so that one can choose that this check shouldn't be done (e.g. --disable-version-check) and it should be non-blocking, should the check not succeed fast enough.

It could compare the version with https://github.com/projectsyn/commodore/releases/latest, this automatically redirects to the latest version (the location header of the response, could be a HEAD).

Alternatives

Users running outdated versions of Commodore.

@tobru tobru added the enhancement New feature or request label Feb 11, 2022
@mhutter
Copy link
Contributor

mhutter commented Feb 11, 2022

Alternative proposal

Instead of connecting to GitHub on each invocation, document the version used to generate the catalog in the catalog itself.

If the current catalog was generated using a more recent version than is currently in use, emmit the warning (or abort or whatever).

Source: I've seen other tools (bundler, yarn) do this to generate their lockfiles.

Edit: Using an outdated version is, in my opinion, not an issue per se. Running an outdated version against a catalog that was compiled using a more recent version on the other hand is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants