Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast.BaseNode.equals shouldn't ignore order for Attributes and Variants #111

Closed
Pike opened this issue Mar 13, 2019 · 0 comments
Closed

ast.BaseNode.equals shouldn't ignore order for Attributes and Variants #111

Pike opened this issue Mar 13, 2019 · 0 comments
Assignees
@Pike
Labels
fluent.syntax Issues related to the fluent.syntax module.

Comments

@Pike
Copy link
Contributor

Pike commented Mar 13, 2019

When talking through this API in fluent.js, we found that ignoring order in Attributes and Variants is actually not the right thing.

Backport this fix to fluent.syntax in python land.
@Pike Pike added the fluent.syntax Issues related to the fluent.syntax module. label Mar 13, 2019
@Pike Pike self-assigned this Mar 13, 2019
@Pike Pike mentioned this issue Mar 13, 2019
Merged
Pike added a commit to Pike/python-fluent that referenced this issue Mar 13, 2019
@Pike
.equals should not ignore Variant and Attribute order, fixes projectf…
7c647df 
…luent#111
Pike added a commit to Pike/python-fluent that referenced this issue Mar 19, 2019
@Pike
.equals should not ignore Variant and Attribute order, fixes projectf…
6b38ad0 
…luent#111

Also remove .sorting_key, it's not used anymore.
@stasm stasm closed this as completed in 9673bf1 Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pike Pike

Labels
fluent.syntax Issues related to the fluent.syntax module.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pike