Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate tests trigger segmentation faults on linux and thus automation #319

Open
Pike opened this issue Jan 6, 2021 · 2 comments
Open

Comments

@Pike
Copy link
Contributor

Pike commented Jan 6, 2021

Running the test:validate tests on linux creates crashes in three tests.

I tested on 12 and 14 on WSL, and travis/github actions also crash. macos version 12 doesn't crash, though.

The tests claim to be passing because the actual crash is in a subprocess that's expected to fail. And the segfault just does that.

@Pike
Copy link
Contributor Author

Pike commented Jan 6, 2021

I've also reproduced with nodejs nightly on WSL.

I've tried a debug build on node 14, but even the jst macro to get the js stack trace doesn't work.

I think this needs someone from the node community that has experience in debugging nodejs/v8 crashes.

Pike added a commit to Pike/fluent that referenced this issue Jan 7, 2021
@Pike
Copy link
Contributor Author

Pike commented Jan 7, 2021

I've create a PR with the modification that triggers the first crash in #321. Just run the following command to reproduce:

node -r esm --stack-size=500000000 test/parser.js ./test/fixtures/any_char.ftl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant