Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow comments in domains file #1333

Closed
dogancanbakir opened this issue Aug 5, 2024 · 0 comments · Fixed by #1346
Closed

Allow comments in domains file #1333

dogancanbakir opened this issue Aug 5, 2024 · 0 comments · Fixed by #1346
Assignees
@dogancanbakir
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@dogancanbakir
Copy link
Member

This pull requests allows the domains file to have comments, prefixed with #. It strips everything after # character, and then does not process empty lines.

I.E.

# ProjectDiscovery
projectdiscovery.org # This is the main site
example.com # This is a demo website

Will be processed as

projectdiscovery.org
example.com

ref: #1215 (comment)
@dogancanbakir dogancanbakir added the Type: Enhancement Most issues will probably ask for additions or changes. label Aug 5, 2024
@dogancanbakir dogancanbakir mentioned this issue Aug 5, 2024
Closed
@dogancanbakir dogancanbakir mentioned this issue Aug 13, 2024
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dogancanbakir dogancanbakir

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
2 participants
@ehsandeep @dogancanbakir