Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -http-directory work with -dynamic-response #741

Closed
ounissi-zakaria opened this issue Dec 23, 2023 · 2 comments · Fixed by #747
Closed

Make -http-directory work with -dynamic-response #741

ounissi-zakaria opened this issue Dec 23, 2023 · 2 comments · Fixed by #747
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@ounissi-zakaria
Copy link
Contributor

Please describe your feature request:

Would it be possible (or a good idea?) to make http-directory files work with -dynamic-response headers/status. example:
request ==> oast.fun/s/evil-image.png?header=content-type:image/svg%2Bxml&status=500

Describe the use case of this feature:

  • Sometimes when the body of the response is big i can't use dynamic response normally and include it in the url
  • Having to write response then url encoding it then copying it to the url is annoying

I forked the repo and made a change for this changes to work. But I am not sure if it's the best approach. you can check the changes here

@ounissi-zakaria ounissi-zakaria added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 23, 2023
@dogancanbakir
Copy link
Member

@ounissi-zakaria, Thanks for taking the initiative to open up this issue and your efforts to make it happen! Could you please raise a PR and let us review it?

@ounissi-zakaria
Copy link
Contributor Author

sure, Here #747

@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants