Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random UA doesn't respect custom UA input #382

Closed
ehsandeep opened this issue Aug 29, 2021 · 0 comments · Fixed by #386 or #411
Closed

Random UA doesn't respect custom UA input #382

ehsandeep opened this issue Aug 29, 2021 · 0 comments · Fixed by #386 or #411
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@ehsandeep
Copy link
Member

Describe the bug
As default, httpx uses random UA, as a user if you try to overwrite with -H 'User-Agent: Test, it doesn’t work.

Expected behavior:-

If User-Agent header is specified manually, Random UA should be disabled and respect the user input.

Environment details
v.1.1.2
@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Aug 29, 2021
@Mzack9999 Mzack9999 linked a pull request Aug 30, 2021 that will close this issue
Disabling automatic UA if user defines one #386
Merged
@rivalsec rivalsec mentioned this issue Sep 6, 2021
Closed
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Sep 6, 2021
@ehsandeep ehsandeep linked a pull request Oct 4, 2021 that will close this issue
v1.1.3 Release preparation #411
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
1 participant
@ehsandeep