Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy v1.11: Investigate using /ready endpoint for probes #1277

Closed
stevesloka opened this issue Jul 26, 2019 · 4 comments · Fixed by #1433
Closed

Envoy v1.11: Investigate using /ready endpoint for probes #1277

stevesloka opened this issue Jul 26, 2019 · 4 comments · Fixed by #1433
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@stevesloka
Copy link
Member

Describe the solution you'd like
Mentioned in #1242, Envoy v1.11.0 introduces a new /ready admin endpoint which improves readiness probes, this might be a nice thing to change for Contour 0.15 too, maybe even improving smoother Envoy rollouts as discussed on #1245

// cc @rochacon

@stevesloka stevesloka added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 26, 2019
@stevesloka
Copy link
Member Author

The only nice thing about the way we expose today is that we don't need to expose the entire admin site to a port for the kubelet to check against. So let's keep that in mind when this is investigated such that we don't accidentally expose that admin UI.

@rochacon
Copy link
Contributor

I've been testing Contour with Envoy 1.11 to evaluate the use of /ready and trim down the steps discussed at #145. It works pretty similar to the current /healthz endpoint, with the addition of a response body with the current state of the server (e.g. LIVE / DRAINING).

Contour requires this patch to passthrough /ready to the admin in the restricted listener (port 8002): master...rochacon:enable-ready-endpoint

I believe we should add the above patch to allow the use of /ready even though it won't change the current probe behavior it allows this more specific endpoint to be used. If you agree I'll open the PR for it.

@stevesloka
Copy link
Member Author

@rochacon yup I think switching over to this endpoint is fine, happy to take a PR!

@davecheney davecheney added this to the 1.0.0-beta.1 milestone Aug 30, 2019
@davecheney
Copy link
Contributor

@rochacon could you send that PR please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants