Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: additional pod metadata #756

Closed
prometherion opened this issue May 4, 2023 · 3 comments · Fixed by #871
Closed

Feature: additional pod metadata #756

prometherion opened this issue May 4, 2023 · 3 comments · Fixed by #871
Assignees
Labels
enhancement New feature or request needs-discussion No outline on the feature, discussion is welcome
Milestone

Comments

@prometherion
Copy link
Member

Describe the feature

Let each Pod running in a Tenant Namespace to inherit a set of labels or annotations defined in the Tenant manifest.

What would the new user story look like?

As a Cluster Administrator, I want to perform traffic shaping in order to allow QoS from the Networking standpoint by labelling and annotating Tenant workloads (pods).

Expected behavior

By defining a set of additional metadata in the Tenant specificaiton each workload created in one of their Namespaces will be labelled or annotated with the required information.

The Tenant Owner doesn't need to know in advance the required labels, Capsule will inject them, and override any user-input to prevent any kind of escalation.

@prometherion prometherion added enhancement New feature or request needs-discussion No outline on the feature, discussion is welcome labels May 4, 2023
@prometherion
Copy link
Member Author

We've been demanded to address traffic shaping (aka QoS, or bandwith management) from a Tenant level.

This could be done using a CNI network plugin, or the Cilium Bandwitdh Manager.

@MaxFedotov @oliverbaehler @bsctl although an overalap with other popular policy engines, I think this feature could be interesting to have it available in the Tenant definition and making it declarative.

Thoughts?

@bsctl
Copy link
Member

bsctl commented May 4, 2023

it would be a very valuable feature, imho

@GiuseppeChiesa-TomTom
Copy link

I support this feature.

We also encounter the same use-case, since we use some other shared cluster components, such as logging agents that can take advantage of pod annotations to enrich the log informations.
For example, with Scalyr/Dataset, you can might set an annotation to define the "tenant" attribute on each pod logline (see: https://app.scalyr.com/help/scalyr-agent-k8s#attaching), and the information can be used to enrich the log entries in the logging backend.
This would be beneficial so that multiple tenants, can use the attributes to easy finding their logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-discussion No outline on the feature, discussion is welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants