Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded namespace for a webhook configurations #448

Closed
prometherion opened this issue Oct 7, 2021 · 0 comments · Fixed by #447
Closed

Hardcoded namespace for a webhook configurations #448

prometherion opened this issue Oct 7, 2021 · 0 comments · Fixed by #447
Assignees
@prometherion
Labels
bug Something isn't working helm
Milestone
v0.1.1

Comments

@prometherion
Copy link
Member

https://github.com/clastix/capsule/blob/52cf59704104eb8c19eda3e2d4af268f9b0373f0/charts/capsule/templates/validatingwebhookconfiguration.yaml#L166

This should be {{ .Release.Namespace }}
@prometherion prometherion added bug Something isn't working helm labels Oct 7, 2021
@prometherion prometherion added this to the v0.1.1 milestone Oct 7, 2021
@prometherion prometherion self-assigned this Oct 7, 2021
@prometherion prometherion linked a pull request Oct 7, 2021 that will close this issue
fix: do not hardcode namespace forwebhook configs #447
Merged
@prometherion prometherion changed the title Hardcode namespace for webhook configurations Hardcoded namespace for a webhook configurations Oct 7, 2021
@prometherion prometherion mentioned this issue Oct 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prometherion prometherion

Labels
bug Something isn't working helm
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging a pull request may close this issue.

fix: do not hardcode namespace forwebhook configs viveksyngh/capsule
1 participant
@prometherion